[skip circleci] Give unique names to post-jobs #2337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jneira
commented
Nov 10, 2021
•
jneira
commented
- To try make required checks work
- Before this if some post_job (from nix or bench workflows) was green and the test post_job did not start, the pr was incorrectly mergeable and mergifyio could merge it. This has happened with Include sortText in completions and improve suggestions #2332 and [skip circleci] Rename hlint test data files and add regression tests #2321
|
@pepeiborra I've changed required checks to ensure we dont merge more prs without ci green, so this one has to be merged before anything else |
Merged
fendor
approved these changes
Nov 10, 2021
yoshitsugu
pushed a commit
to yoshitsugu/haskell-language-server
that referenced
this pull request
Nov 12, 2021
jneira
added a commit
that referenced
this pull request
Nov 15, 2021
* Skip parsing without haddock for above GHC9.0 * Use runtime ghc version check * Need parse twice in getParsedModuleRule * Include sortText in completions and improve suggestions (#2332) * sort completions * add an example * Include fuzzy scores in completions sort text * hlints * Extend completion documentation to inform whether an identifier is alreaady imported * Ditch alphabetical ordering - it's incompatible with qualified completions * Fix bugs in completion help text This fixes the ugly "Imported from 'Just B'" and other inconsistencies * added tests for qualified completions * Fix redundant import * Inline Fuzzy.match to apply [1] and to be case-sensitive on first match [1] - joom/fuzzy#4 * fixup! Fix bugs in completion help text * Sort qualified completions first * Filter out global suggestions that overlap with local For example, don't suggest GHC.Exts.fromList when Data.Map.fromList is in scope alraedy * Sort completions alphabetically * Show provenance in detail text * Sort local/in-scope completions first * Fix build with GHC 9 * Ignore func symbol tests Co-authored-by: Alex Naspo <alex.naspo@protonmail.com> Co-authored-by: Javier Neira <atreyu.bbb@gmail.com> * Give unique names to post-jobs (#2337) * Restore comment * Parse only with Haddock above GHC90 * Remove obsolete comment Co-authored-by: Pepe Iborra <pepeiborra@gmail.com> Co-authored-by: Alex Naspo <alex.naspo@protonmail.com> Co-authored-by: Javier Neira <atreyu.bbb@gmail.com>
pepeiborra
added a commit
that referenced
this pull request
Nov 19, 2021
* Skip parsing without haddock for above GHC9.0 * Use runtime ghc version check * Need parse twice in getParsedModuleRule * Include sortText in completions and improve suggestions (#2332) * sort completions * add an example * Include fuzzy scores in completions sort text * hlints * Extend completion documentation to inform whether an identifier is alreaady imported * Ditch alphabetical ordering - it's incompatible with qualified completions * Fix bugs in completion help text This fixes the ugly "Imported from 'Just B'" and other inconsistencies * added tests for qualified completions * Fix redundant import * Inline Fuzzy.match to apply [1] and to be case-sensitive on first match [1] - joom/fuzzy#4 * fixup! Fix bugs in completion help text * Sort qualified completions first * Filter out global suggestions that overlap with local For example, don't suggest GHC.Exts.fromList when Data.Map.fromList is in scope alraedy * Sort completions alphabetically * Show provenance in detail text * Sort local/in-scope completions first * Fix build with GHC 9 * Ignore func symbol tests Co-authored-by: Alex Naspo <alex.naspo@protonmail.com> Co-authored-by: Javier Neira <atreyu.bbb@gmail.com> * Give unique names to post-jobs (#2337) * Restore comment * Parse only with Haddock above GHC90 * Remove obsolete comment Co-authored-by: Pepe Iborra <pepeiborra@gmail.com> Co-authored-by: Alex Naspo <alex.naspo@protonmail.com> Co-authored-by: Javier Neira <atreyu.bbb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.