Skip to content

Split plugin tests into two cabal projects #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 2, 2021
Merged

Split plugin tests into two cabal projects #1479

merged 3 commits into from
Mar 2, 2021

Conversation

wz1000
Copy link
Collaborator

@wz1000 wz1000 commented Mar 2, 2021

If both tests are part of the same component, we get non-deterministic failures because of diagnostics from the other test.

Its a wonder that nobody caught this before. Guess we are just used to taking abuse from CI.

Should fix #1430 to some extent.

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAny thanks for the fix!

@wz1000 wz1000 changed the title Split plugin tests into two cabal project Split plugin tests into two cabal projects Mar 2, 2021
@wz1000 wz1000 added the merge me Label to trigger pull request merge label Mar 2, 2021
@mergify mergify bot merged commit a4b45da into master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-deterministic CI test failures
2 participants