Skip to content

Less aggressive refine tactic #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 2, 2021

Conversation

isovector
Copy link
Collaborator

@isovector isovector commented Mar 1, 2021

Yesterday's refine hole action (#1463) turns out to be too aggressive. I was dogfooding it this morning and it replace the following hole:

mkNameDetails :: HyInfo CType -> NameDetails
mkNameDetails = _

with

mkNameDetails :: HyInfo CType -> NameDetails
mkNameDetails hi
  = NameDetails
      {nd_orig_name = OccName
                        {occNameSpace = _,
                         occNameFS = FastString
                                       {uniq = _, n_chars = _, fs_bs = _, fs_ref = _}},
       nd_user_given = _, nd_type = CType _, nd_provenance = _}

NO THANK YOU.

This PR makes it not be recursive, so it WILL build NameDetails but it will not build OccName or FastString:

mkNameDetails :: HyInfo CType -> NameDetails
mkNameDetails hi
  = NameDetails
      {nd_orig_name =_,
       nd_user_given = _, nd_type = _, nd_provenance = _}

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES THANK YOU

@googleson78
Copy link
Contributor

Closes #1304

@isovector isovector added the merge me Label to trigger pull request merge label Mar 1, 2021
@mergify mergify bot merged commit 82886f8 into haskell:master Mar 2, 2021
@isovector isovector deleted the less-aggressive-refine branch April 5, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants