-
-
Notifications
You must be signed in to change notification settings - Fork 389
Add haskell.nix shell #1386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add haskell.nix shell #1386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think both nix-ways should be supported or only one of them?
Co-authored-by: fendor <fendor@users.noreply.github.com>
Co-authored-by: fendor <fendor@users.noreply.github.com>
Co-authored-by: fendor <fendor@users.noreply.github.com>
IIUC correctly, this will track changes to the cabal.project file and never break, therefore no need to set up a CI job for it? |
Never say never. Is there a test for |
There is a GitHub action |
FWIW, I'm not sure I'd recommend merging this unless some of the contributors to the project are actually keen on maintaining it! Maintaining other people's Nix code is never fun... |
name: haskell-language-server | ||
authToken: ${{ secrets.HLS_CACHIX_AUTH_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The haskell-language-server
Cachix account is limited to 5GB, so this won't work. I recommend using a different Cachix account for the haskell.nix artifacts, I can set up the token if you share it via email (pepeiborra@gmail.com).
To test it, you will have to open the PR from a GitHub.com/haskell/haskell-language-server branch, otherwise the GitHub action cannot see the token. I've given you push access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've set up the public Cachix account haskell-nix-language-server
and the secret HLS_NIX_CACHIX_AUTH_TOKEN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can set up the token if you share it via email
Sorry, I just saw this. Do you still need me to do this?
I've given you push access
I tried pushing the hkm/haskell-nix branch to haskell/haskell-language-server, but got:
ERROR: Permission to haskell/haskell-language-server.git denied to hamishmack.
Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
It used quite a lot of github minutes building GHC. Is it possible (and would it make sense) to use the IOHK cache instead of cachix (or better yet as an upstream cache if that is possible)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hamishmack hi, some update on this?
I am happy to switch from |
Moreover, do we have any plan to use Flakes? It's an experimental feature, providing functionality similar to niv but more powerful and concise. And there is a flake-compat to help us keep it backward compatible (default.nix and shell.nix will still be available for non-flake users). |
@hamishmack do you still have plans to continue this? |
My use case for this is now covered by Hix. I can check a project builds with haskell.nix by installing or updating Hix as per the getting started guide, then cloning the project:
Add configuration to
To build a project component:
or
To build with
The getting started guide has example |
No description provided.