Skip to content

CI test fails #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fendor opened this issue Jul 29, 2020 · 2 comments · Fixed by #261
Closed

CI test fails #252

fendor opened this issue Jul 29, 2020 · 2 comments · Fixed by #261
Assignees
@lukel97
Labels
CI Continuous integration

Comments

@fendor
Copy link
Collaborator

fendor commented Jul 29, 2020

Seemingly in the latest commits, we have flaky CI results, e.g. some tests fail occasionally. This is really annoying, as it is hard to tell whether this is your PR's fault, or someone else's.
@lukel97 lukel97 self-assigned this Jul 29, 2020
@lukel97
Copy link
Collaborator

lukel97 commented Jul 29, 2020 •
edited
Loading

I broke these trying to get #243 in, so as penance I'll try to fix these! All the tests were passing locally for me on macOS, so I'll need to spend some time debugging CircleCI

@lukel97 lukel97 added the CI Continuous integration label Jul 29, 2020
@lukel97
Copy link
Collaborator

lukel97 commented Jul 31, 2020 •
edited
Loading

I'm not sure if #243 did break these in the end. Looks like these were already kind of flakey here and here, but something is causing them to properly fail now. Perhaps something changed on the CircleCI VM? Cache doesn't seem to have anything to do with it

@lukel97 lukel97 mentioned this issue Jul 31, 2020
Merged
pepeiborra pushed a commit that referenced this issue Dec 27, 2020
@jacg @cocreature
Fix #246 (#252)
2523c21 
* Fix #246

`getTypeLHsBind` returned a single span corresponding to the overall function
binding. The fix drills down into the individual matches and returns a span for
each of them.

Fixes #246.

* Make it work on GHC 8.8

* Cosmetics
@Anton-Latukha Anton-Latukha mentioned this issue Dec 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukel97 lukel97

Labels
CI Continuous integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Slow down Tasty by limiting it to -j1 haskell/haskell-language-server
2 participants
@lukel97 @fendor