prototype: migrate command for terraform stacks #36461
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamcervante
added
the
no-changelog-needed
liamcervante
force-pushed
the
liamcervante/tfstacksmigrate
branch
from
50223a0 to
a6794d7
Compare
liamcervante
force-pushed
the
liamcervante/tfstacksmigrate
branch
from
a6794d7 to
f977c14
Compare
dsa0x
reviewed
Feb 14, 2025
Comment on lines
+564
to
+572
| targetStackAddress := append(current.ConfigAddr(), stackaddrs.StackStep(ref)) | ||
| stack := m.Migration.Config.Stack(targetStackAddress) | ||
|
|
||
| // we have the configurations for the components in this stack, we just | ||
| // need to scope them down to the components that are in the current | ||
| // stack instance. | ||
|
|
||
| for name := range stack.Components { | ||
| configComponentAddress := stackaddrs.ConfigComponent{ |
There was a problem hiding this comment.
It doesn't hurt to leave the code here, but just to validate that my understanding is correct. I don't think this part is actually necessary, especially since we are keeping the tool to just root-level migration for now, i.e no migration into components embedded in child stacks, which is what a StackCall would be
There was a problem hiding this comment.
yes, the mapping doesn't actually have a way of copying data into embedded stacks so this shouldn't ever be triggered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a proof of concept for migrating state between Terraform workspaces and Terraform stacks.