Backport of terraform test: run block names should be valid HCL identifiers into v1.7 #34470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teamterraform
force-pushed
the
backport/liamcervante/34372/grossly-engaging-ibex
branch
from
47cad2a to
5ec929f
Compare
liamcervante
approved these changes
Jan 3, 2024
liamcervante
deleted the
backport/liamcervante/34372/grossly-engaging-ibex
branch
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #34469 to be assessed for backporting due to the inclusion of the label 1.7-backport.
The below text is copied from the body of the original PR.
Validate that run block names are valid HCL identifiers when they are parsed instead of failing with obscure error messages later.
Fixes #34372
Target Release
1.7.0
Draft CHANGELOG entry
BUG FIXES
terraform test: Improve error message for invalid run block names.Overview of commits