Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support node v18 and hapi v21, drop node v12 and hapi v18/19 #322

Merged
merged 7 commits into from
Aug 8, 2022
Merged

Support node v18 and hapi v21, drop node v12 and hapi v18/19 #322

merged 7 commits into from
Aug 8, 2022

Conversation

geek
Copy link
Member

@geek geek commented Jul 18, 2022

  • Support and test on hapi v21, drop support for hapi v19.
  • Test ESM support.

@geek geek added feature New functionality or improvement test Test or coverage breaking changes Change that can breaking existing code dependency Update module dependency labels Jul 18, 2022
@geek geek added this to the 12.0.5 milestone Jul 18, 2022
devinivy
devinivy reviewed Jul 19, 2022
View reviewed changes
@devinivy
Copy link
Member

devinivy commented Jul 19, 2022 •
edited
Loading

@geek The failing tests are due to DNS resolution changes in node v18, in the same vein as hapijs/hapi#4357. If you merge this work into your PR I think they should be resolved: geek/nes@v21-hapi...hapijs:nes:fix-node-v18-tests

@geek geek requested a review from devinivy August 2, 2022 01:58
devinivy
devinivy approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@devinivy devinivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉

@devinivy devinivy self-assigned this Aug 8, 2022
@devinivy devinivy merged commit cfa77a0 into hapijs:master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinivy devinivy devinivy approved these changes

@Nargonath Nargonath Awaiting requested review from Nargonath

@lloydbenson lloydbenson Awaiting requested review from lloydbenson

Assignees

@devinivy devinivy

Labels
breaking changes Change that can breaking existing code dependency Update module dependency feature New functionality or improvement test Test or coverage
Projects
None yet
Milestone
13.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@geek @devinivy @Nargonath