Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client - _reconnect update, single reconnection timer #318

Closed
wants to merge 1 commit into from
Closed

client - _reconnect update, single reconnection timer #318

wants to merge 1 commit into from

Conversation

neemanjabu
Copy link
Contributor

@neemanjabu neemanjabu commented May 16, 2021 •
edited
Loading

do not start another reconnection timer if there is one already started

@devinivy devinivy mentioned this pull request Aug 7, 2022
Merged
devinivy
devinivy approved these changes Aug 7, 2022
View reviewed changes
Copy link
Member

@devinivy devinivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution! I did a little digging to understand this change, and opened #323 which adds a failing test to document this fix.

@devinivy devinivy added this to the 12.0.5 milestone Aug 7, 2022
@devinivy devinivy self-assigned this Aug 7, 2022
@devinivy devinivy added the bug Bug or defect label Aug 7, 2022
@devinivy
Copy link
Member

devinivy commented Aug 7, 2022

This work was merged as a part of #323, so closing 🙏

@devinivy devinivy closed this Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinivy devinivy devinivy approved these changes

Assignees

@devinivy devinivy

Labels
bug Bug or defect
Projects
None yet
Milestone
12.0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@neemanjabu @devinivy