Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to validate and other package updates #311

Merged
merged 1 commit into from
Aug 4, 2020
Merged

switch to validate and other package updates #311

merged 1 commit into from
Aug 4, 2020

Conversation

lloydbenson
Copy link
Contributor

No description provided.

@lloydbenson lloydbenson self-assigned this Aug 3, 2020
@lloydbenson lloydbenson requested review from hueniverse and cjihrig and removed request for hueniverse August 3, 2020 19:43
@lloydbenson
Copy link
Contributor Author

Looks like some of test scenarios are not passing so I'll hold off on this.

@hueniverse
Copy link
Contributor

Tests are flaky. Sometimes need to retry on travis.

@cjihrig
Copy link
Contributor

cjihrig commented Aug 4, 2020

@lloydbenson I restarted the failing jobs, and the CI is now green.

@lloydbenson
Copy link
Contributor Author

Thanks @cjihrig and @hueniverse.

@lloydbenson lloydbenson merged commit 8bdc392 into hapijs:master Aug 4, 2020
@cjihrig cjihrig added this to the 12.0.4 milestone Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

Assignees

@lloydbenson lloydbenson

Labels
None yet
Projects
None yet
Milestone
12.0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@lloydbenson @hueniverse @cjihrig