Add ability to revoke a socket ignoring if it is already closed #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rankida
commented
May 27, 2019
| @@ -931,7 +931,8 @@ describe('Client', () => { | |||
| const a = { b: 1 }; | |||
| a.a = a; | |||
|
|
|||
| const err = await expect(client.request({ method: 'POST', path: '/', payload: a })).to.reject('Converting circular structure to JSON'); | |||
| const err = await expect(client.request({ method: 'POST', path: '/', payload: a })).to.reject(); | |||
| expect(err.message).to.startWith('Converting circular structure to JSON'); | |||
There was a problem hiding this comment.
This is a fix for node 12, as seen https://travis-ci.org/hapijs/nes/jobs/537797710
This is unrelated to my PR.
|
I am going to blame Travis for the failing builds.
This PR now has the same success (or a little more) than |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where there is an
onUnsubscribehandler registered it is possible thatrevokecan be called on a socket that has since been closed. This results in an error being thrown.To prevent having to try/catch and explicitly test for
nes's internalSocket not openerror this new flagthrowIfClosedallows the user to signal their intent to "fire and forget".Because
revokeis async internally it is not possible to catch this with certainty prior to making therevokecall.The added tests demonstrate the issue we are seeing in production.