Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconnect on error #247

Merged
merged 1 commit into from
Jul 2, 2018
Merged

Reconnect on error #247

merged 1 commit into from
Jul 2, 2018

Conversation

lpww
Copy link

@lpww lpww commented Jun 25, 2018

Attempt to reconnect on a websocket error, as recommended in #242

@lpww lpww force-pushed the reconnect-on-error branch from 62888f0 to 982fd81 Compare June 25, 2018 09:55
@mtharrison
Copy link
Contributor

Having testing, it all seems to do what it's supposed to. I've run some IE11 tests in Browserstack too and can confirm that it will reconnect when server restarts unlike before.

@mtharrison mtharrison added the bug Bug or defect label Jul 2, 2018
@mtharrison mtharrison self-assigned this Jul 2, 2018
@mtharrison mtharrison merged commit 2da53bf into hapijs:master Jul 2, 2018
@mtharrison mtharrison added this to the 9.0.1 milestone Jul 2, 2018
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug or defect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants