Add client.onHeartbeatTimeout hook #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I suppose this closes #240 too? |
|
Yes, I referenced the PR by mistake. Thanks. |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hook notifies user immediately when a disconnection is initiated due to heartbeat timeout, so they can take action. Previously the only option was to wait for
onDisconnectionwhich isn't called until server close frame is received. This leaves a gap between the timeout and disconnection proper when the client is unaware that the connection is not usable.In future we may make more radical changes to the hooks, such as calling
onDisconnect()as soon as the timeout occurs but this is a simple backwards-compatible change that addresses the issue.Closes #241
cc @dominykas