Readme tweaks #54
Readme tweaks #54
Conversation
|
Does this need a |
|
Not necessarily if we maintain the toc by hand.
Tell me then if I should remove it or no.
|
|
I have no opinion. I hate the API.md idea. So, whatever makes it work properly is fine with me. |
|
Toc generation is independent from the API.md decision, though it has helped me a lot consistently getting the toc right and avoiding useless PRs. Your choice. |
|
I added then the toc generation from joi. |
| @@ -16,11 +16,14 @@ | |||
| "hoek": "3.x.x" | |||
| }, | |||
| "devDependencies": { | |||
| "lab": "7.x.x" | |||
| "lab": "8.x.x", | |||
| "markdown-toc": "^0.12.3" | |||
There was a problem hiding this comment.
Can't guarantee it'll keep working with a 0.x version, this should be made sticky to 0.12 as joi did.
There was a problem hiding this comment.
you mean keep lab 7?
There was a problem hiding this comment.
No, markdown-toc. Semver doesn't really apply the same way prior to v1.x.x. Can you drop the ^
There was a problem hiding this comment.
okey dokey.
Didn't know about that.
Shall I made a dedicated PR?
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Extract Api.md so it would be more easy to include it with hapijs.com plugin pages.