Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve typings #163

Merged
merged 4 commits into from
Nov 5, 2021
Merged

Improve typings #163

merged 4 commits into from
Nov 5, 2021

Conversation

kanongil
Copy link
Contributor

@kanongil kanongil commented Apr 8, 2021

This PR includes 1 patch to loosen types to fix #162, 1 to add a missing NaN() method, and 2 patches that tightens the types.

The 24de1bc commit is the most invasive, and splits type specific methods off, so that they won't appear unless they can be used on the expected type. Eg. these will now fail the type check:

expect(true).to.startWith('t');
expect('123').to.be.greaterThan(10);
await expect(() => 'hi').to.reject();

All of these patches should probably be considered bug fixes.

@kanongil kanongil added the types TypeScript type definitions label Apr 8, 2021
@kanongil kanongil mentioned this pull request Apr 8, 2021
@kanongil
Copy link
Contributor Author

kanongil commented Nov 5, 2021

Ping?

@Nargonath Nargonath added the bug Bug or defect label Nov 5, 2021
@Nargonath
Copy link
Member

Per your comment

All of these patches should probably be considered bug fixes.

I added the bug label. This is to set the scene for timetrack.

@devinivy devinivy added this to the 8.0.4 milestone Nov 5, 2021
@devinivy devinivy merged commit b281de5 into hapijs:master Nov 5, 2021
@devinivy
Copy link
Member

devinivy commented Nov 5, 2021

This is now released in 8.0.4 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug or defect types TypeScript type definitions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type error on .include()
3 participants