-
Notifications
You must be signed in to change notification settings - Fork 706
Partial #2975 - Deprecate v1 Menu
classes
#4013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tig
wants to merge
71
commits into
gui-cs:v2_develop
Choose a base branch
from
tig:v2_2975-v1Menu-Obsolete
base: v2_develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+4,699
−1,879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
This was referenced Apr 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 49 out of 49 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
Terminal.Gui/Views/FlagSelector.cs:437
- The condition in the UncheckNone method unchecks all checkboxes except those labeled 'None', which may be unintended. Consider changing the condition to check for equality ('sv.Title == "None"') to only uncheck the 'None' checkbox.
foreach (CheckBox cb in SubViews.OfType<CheckBox> ().Where (sv => sv.Title != "None"))
Terminal.Gui/Views/Menu/PopoverMenu.cs:408
- [nitpick] If the commented-out border styling code is no longer needed, consider removing it for clarity. Otherwise, add an explanatory comment describing its retention.
//menu.Border.Thickness = new (1);
…2_2975-v1Menu-Obsolete
…2_2975-v1Menu-Obsolete
Fixed a few bugs. Code cleanup.
…2_2975-v1Menu-Obsolete
…2_2975-v1Menu-Obsolete
This was referenced Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Menu
- Base onBar
and address litany of issues #2975HighlightStyle.Hover
causesColorScheme
issues #4014GetNormalColor
etc.... #4016Proposed Changes/Todos
UICatalog
bugs inv2win/v2net
HighlightStyle.Hover
causesColorScheme
issues #4014GetNormalColor
etc.... #4016Pull Request checklist:
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)