Skip to content

fix: rideshare tweaks #4075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

fix: rideshare tweaks #4075

wants to merge 13 commits into from
+55 −59

Conversation

shelldandy
Copy link
Contributor

@shelldandy shelldandy commented Apr 3, 2025 •
edited
Loading

Continues from: #4011

Needed to add the utf8 metrics to our prometheus config so they're properly scrapped

image

@shelldandy shelldandy marked this pull request as ready for review April 3, 2025 22:09
@shelldandy shelldandy requested a review from a team as a code owner April 3, 2025 22:09
@shelldandy shelldandy requested a review from marcsanmi April 5, 2025 02:54
@grafakus grafakus mentioned this pull request Apr 8, 2025
Open
marcsanmi
marcsanmi reviewed Apr 10, 2025
View reviewed changes
Copy link
Contributor

@marcsanmi marcsanmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing and it'd be ready to merge 🙂

@shelldandy shelldandy requested a review from marcsanmi April 14, 2025 14:12
marcsanmi
marcsanmi reviewed Apr 15, 2025
View reviewed changes
Copy link
Contributor

@marcsanmi marcsanmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shelldandy,
I still see the a.utf8.metric being added. It's breaking the experience in some screens, such as in the metrics explorer, as I showed in the last comment.

When addressing that, could you take the chance to update the branch? Thanks for all the work! 🙂

@shelldandy
Copy link
Contributor Author

Hi @shelldandy,

I still see the a.utf8.metric being added. It's breaking the experience in some screens, such as in the metrics explorer, as I showed in the last comment.

When addressing that, could you take the chance to update the branch? Thanks for all the work! 🙂

The metric is still there but without the emoji like before, is that still a problem? I'm only using normal characters in there.

I'll update the branch as well no problem

@marcsanmi
Copy link
Contributor

The metric is still there but without the emoji like before, is that still a problem? I'm only using normal characters in there.

Yes, "." aren't supported :(

432264911-2714eb0c-700b-4d51-94db-1a7794a223d6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcsanmi marcsanmi marcsanmi requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shelldandy @marcsanmi @grafakus