Upgrade Java and Python Integration Example #225
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
LesiaChaban
force-pushed
the
ls/graalpy-notebook-example
branch
from
8f66be6 to
2f99a72
Compare
| java-version: ${{ matrix.java-version }} | ||
| distribution: 'graalvm' | ||
| components: 'python' |
There was a problem hiding this comment.
You can't install 'python' component on GraalVM for JDK 21. We should keep this demo testing on java-version: '17'.
There was a problem hiding this comment.
That's one option. As I understand, you need to install GraalPy JVM standalone 23.1.1 and export GRAALPY_HOME to to using GitHub actions workflow.
There was a problem hiding this comment.
If we decide to update this demo to a newer version of GraalPy, we no longer can/should use the setup-graalvm action, but you may be able to use setup-python, which supports GraalPy.
There was a problem hiding this comment.
This demo is about an embedding, it should not install GraalPy in the action at all, only through the pom dependency
| <files> | ||
| <file>${env.JAVA_HOME}/bin/graalpy</file> |
There was a problem hiding this comment.
Why do we need to change the env name?
There was a problem hiding this comment.
It doesn’t change the env name. The name of env is here <argument>venv</argument>.
| ``` | ||
| 2. Download and install GraalPy using `pyenv`: | ||
| ```bash | ||
| pyenv install graalpy-23.1.0 |
| java-version: ${{ matrix.java-version }} | ||
| distribution: 'graalvm' | ||
| components: 'python' |
There was a problem hiding this comment.
This demo is about an embedding, it should not install GraalPy in the action at all, only through the pom dependency
There was a problem hiding this comment.
I'm afraid this file should be removed
There was a problem hiding this comment.
I'm afraid this entire pom.xml needs to be rewritten to use the graalpy-maven-plugin for 24.0, is it worth updating now?
There was a problem hiding this comment.
Are we going to publish our graalpy-maven-plugin? That's great news if so!
There was a problem hiding this comment.
yes, it goes out with the next release
There was a problem hiding this comment.
So @olyagpl we wait and refactor the Maven plugin for GraalPy (when it comes out)? Leave GitHub workflow running with JDK 17?
No description provided.