-
Notifications
You must be signed in to change notification settings - Fork 130
ci: linkage monitor CI job to use build.sh #878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the GitHub Actions configuration for Linkage Monitor. Before this change, the CI configuration has "mvn install" command with 6 options. It turned out that a slight difference in the command line option from "build.sh" fails the build in google-auth-library-java repository (GoogleCloudPlatform/cloud-opensource-java#1941). (@Neenu1995 found the build failure. Thanks!) Therefore, this change updates the configuration so that Linkage Monitor job just uses "build.sh" to install the artifacts into local Maven repository. # How did I test? I tested this change in java-spanner repository with this draft PR: #868 <img width="889" alt="Screen Shot 2021-02-12 at 16 54 18" src="https://user-images.githubusercontent.com/28604/107826467-f3cd5c80-6d52-11eb-86f1-1a8053326978.png"> It succeeded. Source-Author: Tomo Suzuki <suztomo@google.com> Source-Date: Tue Feb 16 15:56:09 2021 -0500 Source-Repo: googleapis/synthtool Source-Sha: f327d3b657a63ae4a8efd7f011a15eacae36b59c Source-Link: googleapis/synthtool@f327d3b
Codecov Report
@@ Coverage Diff @@
## master #878 +/- ##
============================================
- Coverage 85.12% 85.12% -0.01%
+ Complexity 2591 2590 -1
============================================
Files 143 143
Lines 14154 14154
Branches 1366 1366
============================================
- Hits 12049 12048 -1
- Misses 1537 1538 +1
Partials 568 568
Continue to review full report at Codecov.
|
chingor13
approved these changes
Feb 17, 2021
ansh0l
pushed a commit
to ansh0l/java-spanner
that referenced
this pull request
Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will update the corresponding PR to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot will not create any more regeneration PRs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs once per night. If you have been assigned to review this PR, please: - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. That will prompt genbot to assign reviewers to the google-cloud-go PR. Corresponding google-cloud-go PR: googleapis/google-cloud-go#6509 Changes: chore: regenerate API index Source-Link: googleapis/googleapis@ad7ddfa feat(aiplatform): add WriteFeatureValues in aiplatform v1beta1 featurestore_online_service.proto PiperOrigin-RevId: 467107520 Source-Link: googleapis/googleapis@0dd9815 chore: regenerate API index Source-Link: googleapis/googleapis@a50718e feat: Public protos for Cloud Connectors API Based on: https://cloud.google.com/apigee/docs/reference/apis/connectors/rest PiperOrigin-RevId: 467068985 Source-Link: googleapis/googleapis@a23f8c6 chore: regenerate API index Source-Link: googleapis/googleapis@be827be feat: publish apikeys/v2 API PiperOrigin-RevId: 466817087 Source-Link: googleapis/googleapis@31f3dd8 chore: regenerate API index Source-Link: googleapis/googleapis@a412f68 feat(asset): Release of query system Committer: lvv@ PiperOrigin-RevId: 466748663 Source-Link: googleapis/googleapis@80d630f docs(documentai): fix minor docstring formatting PiperOrigin-RevId: 466493520 Source-Link: googleapis/googleapis@c2674a3 feat(bigquery/migration): Add MySQL dialect to bigquerymigration v2 client library PiperOrigin-RevId: 466417698 Source-Link: googleapis/googleapis@2bafaf1 chore: regenerate API index Source-Link: googleapis/googleapis@164f1fa feat(documentai): Added field_mask to ProcessRequest object in document_processor_service.proto feat: Added parent_ids to Revision object in document.proto feat: Added integer_values, float_values and non_present to Entity object in document.proto feat: Added corrected_key_text, correct_value_text to FormField object in document.proto feat: Added OperationMetadata resource feat!: Added Processor Management and Processor Version support to v1 library BREAKING CHANGE: Changed the name field for ProcessRequest and BatchProcessorRequest to accept * so the name field can accept Processor and ProcessorVersion. PiperOrigin-RevId: 466168406 Source-Link: googleapis/googleapis@19bf693 chore: regenerate API index Source-Link: googleapis/googleapis@d0de369 feat(asset): Add client library support for AssetService v1 BatchGetEffectiveIamPolicies API Committer: haochunzhang@ PiperOrigin-RevId: 466134014 Source-Link: googleapis/googleapis@63c73fb fix: set longer polling timeouts for filestore UpdateInstance PiperOrigin-RevId: 466057148 Source-Link: googleapis/googleapis@d89cf3d docs: refer to request field by correct name: routing_preference PiperOrigin-RevId: 466038028 Source-Link: googleapis/googleapis@a6aca40
rajatbhatta
pushed a commit
to rajatbhatta/java-spanner
that referenced
this pull request
Nov 17, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: spanner
Issues related to the googleapis/java-spanner API.
cla: yes
This human has signed the Contributor License Agreement.
context: full
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was generated using Autosynth. 🌈
Synth log will be available here:
https://source.cloud.google.com/results/invocations/96c62e92-13ae-4f3c-9727-c854ec8b7488/targets
Source-Link: googleapis/synthtool@f327d3b