feat: [Internal] client-side metrics for afe latency and connectivity error #3819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
rahul2393
added
the
do not merge
HailongWen
reviewed
Apr 15, 2025
google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/HeaderInterceptor.java
Outdated
Show resolved
Hide resolved
HailongWen
reviewed
Apr 15, 2025
...ud-spanner/src/test/java/com/google/cloud/spanner/OpenTelemetryBuiltInMetricsTracerTest.java
Outdated
Show resolved
Hide resolved
HailongWen
reviewed
Apr 15, 2025
...ud-spanner/src/test/java/com/google/cloud/spanner/OpenTelemetryBuiltInMetricsTracerTest.java
Show resolved
Hide resolved
HailongWen
reviewed
Apr 15, 2025
...ud-spanner/src/test/java/com/google/cloud/spanner/OpenTelemetryBuiltInMetricsTracerTest.java
Show resolved
Hide resolved
surbhigarg92
force-pushed
the
revert-3818-revert-3724-afe_metric
branch
from
b3df6dc to
e3e05fb
Compare
surbhigarg92
force-pushed
the
revert-3818-revert-3724-afe_metric
branch
from
12f1a4b to
0bf8f4c
Compare
surbhigarg92
force-pushed
the
revert-3818-revert-3724-afe_metric
branch
2 times, most recently
from
2577419 to
ac53806
Compare
surbhigarg92
force-pushed
the
revert-3818-revert-3724-afe_metric
branch
from
ac53806 to
128d325
Compare
surbhigarg92
changed the title
surbhigarg92
removed
the
do not merge
google-cloud-spanner/src/main/java/com/google/cloud/spanner/BuiltInMetricsConstant.java
Show resolved
Hide resolved
| @@ -689,6 +689,10 @@ private static boolean isEmulatorEnabled(SpannerOptions options, String emulator | |||
| && options.getHost().endsWith(emulatorHost); | |||
| } | |||
|
|
|||
| public static boolean isEnableAFEServerTiming() { | |||
There was a problem hiding this comment.
nit: why are we not using SpannerOptions?
There was a problem hiding this comment.
This feature can only be disabled using ENV .
sakthivelmanii
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.