Skip to content

feat: add support for Python 3.11 #1973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 30, 2022

Conversation

ziegenberg
Copy link
Contributor

@ziegenberg ziegenberg commented Nov 10, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1972 🦕

This also fixes a FutureWarning from pandas

In a future version of pandas all arguments of StringMethods.rsplit except for the argument 'pat' will be keyword-only.

This also fixes a deprecation happening in Python 3.11

DeprecationWarning: inspect.getargspec() is deprecated since Python 3.0

With Python 3.11 inspect.getargspec() was removed. The recommendation is to use inspect.getfullargspec().

See: https://docs.python.org/3.10/library/inspect.html#inspect.getargspec

Deprecated since version 3.0: Use getfullargspec() for an updated API
that is usually a drop-in replacement, but also correctly handles
function annotations and keyword-only parameters.

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@ziegenberg ziegenberg requested a review from a team as a code owner November 10, 2022 20:48
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Nov 10, 2022
ziegenberg and others added 3 commits November 10, 2022 22:04
In a future version of pandas all arguments of StringMethods.rsplit except for the argument 'pat' will be keyword-only.

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
…hon 3.0

With Python 3.11 `inspect.getargspec()` was removed. The recommendation
is to use `inspect.getfullargspec()`.

See: https://docs.python.org/3.10/library/inspect.html#inspect.getargspec

> Deprecated since version 3.0: Use `getfullargspec()` for an updated API
> that is usually a drop-in replacement, but also correctly handles
> function annotations and keyword-only parameters.

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 16, 2022
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 16, 2022
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 16, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 16, 2022
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 16, 2022
@parthea parthea added owlbot:run Add this label to trigger the Owlbot post processor. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 16, 2022
@parthea parthea added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 16, 2022
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 16, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 16, 2022
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 16, 2022
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 16, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 16, 2022
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 18, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 18, 2022
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 29, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 29, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 29, 2022
@parthea parthea merged commit 1106672 into googleapis:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for Python 3.11
3 participants