-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat: add support for Python 3.11 #1973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
In a future version of pandas all arguments of StringMethods.rsplit except for the argument 'pat' will be keyword-only. Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
…hon 3.0 With Python 3.11 `inspect.getargspec()` was removed. The recommendation is to use `inspect.getfullargspec()`. See: https://docs.python.org/3.10/library/inspect.html#inspect.getargspec > Deprecated since version 3.0: Use `getfullargspec()` for an updated API > that is usually a drop-in replacement, but also correctly handles > function annotations and keyword-only parameters. Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
parthea
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1972 🦕
This also fixes a FutureWarning from pandas
In a future version of pandas all arguments of
StringMethods.rsplit
except for the argument 'pat' will be keyword-only.This also fixes a deprecation happening in Python 3.11
DeprecationWarning: inspect.getargspec() is deprecated since Python 3.0
With Python 3.11
inspect.getargspec()
was removed. The recommendation is to useinspect.getfullargspec()
.See: https://docs.python.org/3.10/library/inspect.html#inspect.getargspec