Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/net
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 85d1d54
Choose a base ref
...
head repository: golang/net
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e1fcd82
Choose a head ref
  • 9 commits
  • 25 files changed
  • 7 contributors

Commits on Mar 5, 2025

  1. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    
    Change-Id: I1572a13b12dce8520f2b7f74c6516a6f1f6c9822
    Reviewed-on: https://go-review.googlesource.com/c/net/+/655038
    Auto-Submit: Gopher Robot <gobot@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: David Chase <drchase@google.com>
    gopherbot committed Mar 5, 2025
    Configuration menu
    Copy the full SHA
    99b3ae0 View commit details
    Browse the repository at this point in the history
  2. websocket: re-recommend gorilla/websocket

    Undoes CL 457356 now that it has new maintainers.
    
    Change-Id: I4e05c72d5dec98f7893e6bea38db19916fc03bbb
    Reviewed-on: https://go-review.googlesource.com/c/net/+/655195
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Reviewed-by: Damien Neil <dneil@google.com>
    Auto-Submit: Damien Neil <dneil@google.com>
    seankhliao authored and gopherbot committed Mar 5, 2025
    Configuration menu
    Copy the full SHA
    2914f46 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2025

  1. http2/h2c: use ResponseController for hijacking connections

    Fixes golang/go#71999
    
    Change-Id: I38b236e47bc5893c5a84ef33abbeab0828125bd2
    Reviewed-on: https://go-review.googlesource.com/c/net/+/655615
    Reviewed-by: Junyang Shao <shaojunyang@google.com>
    Reviewed-by: Damien Neil <dneil@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    seankhliao committed Mar 8, 2025
    Configuration menu
    Copy the full SHA
    55989e2 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2025

  1. http2: improve handling of lost PING in Server

    This addresses inconsistencies in handling lost PINGs
    between Server and Transport by:
    1. Always logging a message for lost PINGs, regardless of verbose mode.
    2. Invoking CountError with the conn_close_lost_ping error key.
    
    Fixes golang/go#69963
    
    Change-Id: I58fee489f7896dbb80ccc50265452cd953f7ca6b
    GitHub-Last-Rev: ef74c95
    GitHub-Pull-Request: #229
    Reviewed-on: https://go-review.googlesource.com/c/net/+/635555
    Auto-Submit: Sean Liao <sean@liao.dev>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Sean Liao <sean@liao.dev>
    Reviewed-by: Damien Neil <dneil@google.com>
    Reviewed-by: David Chase <drchase@google.com>
    Choraden authored and gopherbot committed Mar 10, 2025
    Configuration menu
    Copy the full SHA
    09731f9 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2025

  1. html: ensure <search> tag closes <p> and update tests

    This change ensures that the <search> tag correctly closes an open <p> tag when encountered during parsing.
    
    Changes:
    - Added <search> to the list of elements that should close an open <p> tag in parse.go.
    - Updated the second list in parse.go to ensure consistency.
    - Updated html/atom/gen.go, table.go, and table_test.go accordingly.
    - Modified parse_test.go to use strings.Builder instead of bytes.Buffer.
    - Updated test error messages to follow Go’s conventions.
    - Fixed an accidental colon in the comment in parse.go.
    
    Change-Id: I5835da69f6bb0e14c483e55b7ae82915ae958dc1
    Reviewed-on: https://go-review.googlesource.com/c/net/+/655457
    Reviewed-by: Damien Neil <dneil@google.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Auto-Submit: Ian Lance Taylor <iant@google.com>
    Volentie authored and gopherbot committed Mar 12, 2025
    Configuration menu
    Copy the full SHA
    312450e View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2025

  1. http2: improve error when server sends HTTP/1

    If for some reason the server sends an HTTP/1.1 response
    starting with "HTTP/1.1 " (9 bytes), http2 transport interprets that as
    a valid frame header for an expected payload of ~4MB, and fails with
    non-descriptive messages like "unexpected EOF".
    
    This could happen, for example, if ALPN is misconfigured on the server's
    load balancer.
    
    This change attempts to improve that feedback by noting in the error
    messages whenever the frame header was exactly the "HTTP/1.1 " bytes.
    
    Change-Id: I7bf9ed2ee7f299b939b9004386f5bfa30a4e9032
    GitHub-Last-Rev: d6e410d
    GitHub-Pull-Request: #224
    Reviewed-on: https://go-review.googlesource.com/c/net/+/623155
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: David Chase <drchase@google.com>
    Auto-Submit: Sean Liao <sean@liao.dev>
    Reviewed-by: Damien Neil <dneil@google.com>
    Reviewed-by: Sean Liao <sean@liao.dev>
    colega authored and gopherbot committed Mar 13, 2025
    Configuration menu
    Copy the full SHA
    1215081 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2025

  1. publicsuffix: regenerate table

    Updated to revision 2c960dac3d39ba521eb5db9da192968f5be0aded
    (2025-03-18T07:22:13Z).
    Last updated on 2023-08
    
    xn--czrw28b.tw / 商業.tw was removed in publicsuffix/list#2289
    blogspot ccTLDs were removed in publicsuffix/list#2327
    
    Change-Id: I749d014ab667502d9a112e0be645413ec6a7a66e
    Reviewed-on: https://go-review.googlesource.com/c/net/+/659276
    Reviewed-by: Damien Neil <dneil@google.com>
    Reviewed-by: Cherry Mui <cherryyz@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    seankhliao committed Mar 20, 2025
    Configuration menu
    Copy the full SHA
    1f1fa29 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2025

  1. internal/http3: fix build of tests with GOEXPERIMENT=nosynctest

    The tests in qpack_decode_test.go require synctest helpers from
    http3_test.go, but that file has a goexperiment.synctest build
    constraint.
    
    To make builds work when GOEXPERIMENT=nosynctest is specified the
    synctest helpers are refactored into http3_synctest_test.go (with the
    same build constraint) and the non-synctest related functionality is
    kept in http3_test.go.
    
    Change-Id: Iae339dc1895f27e7ac5ba985e204f4868c229a4d
    Reviewed-on: https://go-review.googlesource.com/c/net/+/660535
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Damien Neil <dneil@google.com>
    chressie committed Mar 25, 2025
    Configuration menu
    Copy the full SHA
    ebed060 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2025

  1. html: properly handle trailing solidus in unquoted attribute value in…

    … foreign content
    
    The parser properly treats tags like <p a=/> as <p a="/">, but the
    tokenizer emits the SelfClosingTagToken token incorrectly. When the
    parser is used to parse foreign content, this results in an incorrect
    DOM.
    
    Thanks to Sean Ng (https://ensy.zip) for reporting this issue.
    
    Fixes golang/go#73070
    Fixes CVE-2025-22872
    
    Change-Id: I65c18df6d6244bf943b61e6c7a87895929e78f4f
    Reviewed-on: https://go-review.googlesource.com/c/net/+/661256
    Reviewed-by: Neal Patel <nealpatel@google.com>
    Reviewed-by: Roland Shoemaker <roland@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    rolandshoemaker authored and gopherbot committed Mar 27, 2025
    Configuration menu
    Copy the full SHA
    e1fcd82 View commit details
    Browse the repository at this point in the history
Loading