-
Notifications
You must be signed in to change notification settings - Fork 18k
cmd/internal/obj/wasm: use i64 for large return addr #73277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: 267d9a1) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/663995. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/663995. |
Message from Zxilly Chou: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/663995. |
Message from Cherry Mui: Patch Set 2: Code-Review+2 Commit-Queue+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/663995. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-04-09T06:38:31Z","revision":"d1e353ee2bf300fa6437f8fc27c8dbbd286cfc3b"} Please don’t reply on this GitHub thread. Visit golang.org/cl/663995. |
Message from Cherry Mui: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/663995. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/663995. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/663995. |
Message from Zxilly Chou: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/663995. |
Message from Dmitri Shuralyov: Patch Set 3: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/663995. |
Use i64 to avoid overflow when getting PC_F from the return addr. Fixes #73246 Change-Id: I5683dccf7eada4b8536edf53e2e83116a2f6d943 GitHub-Last-Rev: 267d9a1 GitHub-Pull-Request: #73277 Reviewed-on: https://go-review.googlesource.com/c/go/+/663995 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com>
This PR is being closed because golang.org/cl/663995 has been merged. |
Use i64 to avoid overflow when getting PC_F from the return addr.
Fixes #73246