-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support uid:// in more places #99286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This resolves my issue and seems to be a better solution, as it eliminates the need for manual conversions everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess at the end of the day, best solution is simplest solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
125cde8
to
4da8f49
Compare
@syntaxerror247 Please check again. |
@KoBeWi Still same error with gradle export. Boot splash doesn't throw error now but icon is still not visible. |
4da8f49
to
3b6705a
Compare
Eh, I'm not sure if it's related to UIDs anymore. The error you posted clearly says that res:// file is missing. I can't locate where the gradle error comes from. |
I’m still confident this issue is related to UIDs. Today, I compiled the engine with and without your PR. The boot splash error occurs in both variants, but in the latter, I can workaround it by setting the boot splash logo using 4.4 dev4 and then export with my custom build. This strongly suggests that the issue is related to UIDs. Regarding the Gradle build issue: without this PR, I encounter problems with setting adaptive icons, but at least the build completes. However, with this PR, the build doesn’t even start and fails immediately. |
@KoBeWi I've fixed both issues in my fork, building on your work. I'll create a PR to supersede this one. |
@syntaxerror247 I don't see why your PR would supersede mine, just remove the changes except Android ones. This PR was already reviewed and approved, so it can be merged right now. |
@KoBeWi I wasn't sure what to do, would it be possible to include my changes in this PR? EDIT: I have updated my PR to only include fix for android issues. |
Thanks! |
is there a way to remove those uids? They are horrible for git based projects |
No. |
Adds
uid://
support for Image, FileAccess and ProjectSettings.Fixes #99221
Supersedes #99278