Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary _3D_DISABLED checks in Performance #98946

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

timothyqiu
Copy link
Member

The list will be indexed with a Monitor enum directly. So these entries should not be skipped when 3D is disabled, otherwise subsequent values will be misplaced.

Practically, these two methods in question are only used internally in editor code, and editor builds cannot disable 3D :)

@timothyqiu timothyqiu requested a review from a team as a code owner November 8, 2024 04:02
@AThousandShips AThousandShips added this to the 4.4 milestone Nov 8, 2024
@Repiteo Repiteo merged commit fd4bddb into godotengine:master Nov 22, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 22, 2024

Thanks!

@timothyqiu timothyqiu deleted the 3d-index branch November 23, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants