Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more property hint ranges for project settings #98554

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 26, 2024

  • Tweak property hint ranges for some networking settings to ensure the minimum values don't break the debugger entirely.
  • Ensure shader time rollover is set to at least 1, as 0 causes a division by zero to occur.

All relevant project settings are now covered by a range hint.

@Calinou Calinou requested review from a team as code owners October 26, 2024 14:21
@Calinou Calinou added this to the 4.4 milestone Oct 26, 2024
@Calinou Calinou force-pushed the add-property-hint-ranges branch from c9f89fd to 9104cfb Compare November 11, 2024 16:08
@Calinou Calinou force-pushed the add-property-hint-ranges branch from 9104cfb to 5e653bb Compare December 13, 2024 01:32
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look reasonable

servers/physics_server_2d.cpp Outdated Show resolved Hide resolved
servers/physics_server_3d.cpp Outdated Show resolved Hide resolved
- Tweak property hint ranges for some networking settings to ensure
  the minimum values don't break the debugger entirely.
- Ensure shader time rollover is set to at least 1, as 0 causes a division by
  zero to occur.

All relevant project settings are now covered by a range hint.
@Calinou Calinou force-pushed the add-property-hint-ranges branch from 5e653bb to 62c1791 Compare December 23, 2024 17:22
@akien-mga akien-mga merged commit 0d710da into godotengine:master Jan 3, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants