support the open-icon of folder #34168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
|
I think we need to decouple the "basic theme" and "material theme" In history, the "material theme" ever used "basic theme" folder icons because the "parent directory icon" was hard-coded. But now, I think we have the chance to clearly define different icons. Only use material icons when the theme is material. |
github-actions
bot
added
the
modifies/templates
According to your suggestion, I've newly submitted two commits. I'm not sure if they achieve the decoupling you mentioned. |
…eeEntry` to `FileEntry` to decouple it from `git.TreeEntry`. This change will allow integrating the file icons of the file tree on the diff page into the unified rendering logic without relying on `git.TreeEntry`.
…"folderIconHTMLByOpenStatus" to achieve a consistent style.
|
Please wait for " Mark parent directory as viewed when all files are viewed #33958 " to make the diff file tree right first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.