Add more Links to Comments #25049
Open
Add more Links to Comments #25049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
delvh
reviewed
Jun 3, 2023
Comment on lines
+1558
to
+1571
| if comment.Milestone != nil && comment.Milestone.ID != -1 { | ||
| err = comment.Milestone.LoadRepo(ctx) | ||
| if err != nil { | ||
| ctx.ServerError("LoadMilestoneRepo", err) | ||
| return | ||
| } | ||
| } | ||
| if comment.OldMilestone != nil && comment.OldMilestone.ID != -1 { | ||
| err = comment.OldMilestone.LoadRepo(ctx) | ||
| if err != nil { | ||
| ctx.ServerError("LoadMilestoneRepo", err) | ||
| return | ||
| } | ||
| } |
There was a problem hiding this comment.
I recommend two separate methods Comment#LoadMilestone and Comment#LoadOldMilestone
|
|
||
| // Link returns the milestone Link | ||
| func (m *Milestone) Link() string { | ||
| return fmt.Sprintf("%s/milestone/%d", m.Repo.HTMLURL(), m.ID) |
There was a problem hiding this comment.
You want m.Repo.Link here.
HTMLURL is absolute while Link should be relative.
There was a problem hiding this comment.
Suggested change
| return fmt.Sprintf("%s/milestone/%d", m.Repo.HTMLURL(), m.ID) | |
| return fmt.Sprintf("%s/milestone/%d", m.Repo.Link(), m.ID) |
| @@ -209,7 +217,7 @@ | |||
| {{if eq .Poster.ID .Assignee.ID}} | |||
| {{$.locale.Tr "repo.issues.remove_self_assignment" $createdStr | Safe}} | |||
| {{else}} | |||
| {{$.locale.Tr "repo.issues.remove_assignee_at" (.Poster.GetDisplayName|Escape) $createdStr | Safe}} | |||
| {{$.locale.Tr "repo.issues.remove_assignee_at" (printf `<a href="%s">%s</a>` .Poster.HomeLink (.Poster.GetDisplayName|Escape)) $createdStr | Safe}} | |||
There was a problem hiding this comment.
We are adding the same exact call that many times that we should perhaps extract it into a separate function.
There was a problem hiding this comment.
This is only used in this template. Do we really need a own function for for every object something that is used in a single template a few times?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The events in the Comment history have now Links. e.g. If foo added this to the bar milestone, appears in the Comments, bar is now a Link to the bar Milestone. On the UI Side nothing changed. Everything looks the same.