Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort domains before display #3

Merged
merged 2 commits into from
Sep 22, 2019
Merged

Sort domains before display #3

merged 2 commits into from
Sep 22, 2019

Conversation

cyriac
Copy link
Contributor

@cyriac cyriac commented Sep 20, 2019

What does this implement/fix? Explain your changes.

Domains are sorted in a hierarchically before displaying. This helps with readability.
eg:

test.google.com
google.com
www.google.com
test2.test.google.com

becomes

google.com
test.google.com
test2.test.google.com
www.google.com

Does this close any currently open issues?

Any relevant logs, error output, etc?

Any other comments?

Where has this been tested?

Operating System: Mac OSX 10.14.6

Platform: Python 3.6.5

Target Platform: -

@gnebbia gnebbia merged commit dcad375 into gnebbia:master Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyriac @gnebbia