JS: handle case-insensitive lodash imports #640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failure. |
|
Adding Evaluation on big-apps looks ok. PTAL |
|
The test failure seems to be from Jenkins having trouble, but there's no rush to land this so I'll just retry the tests after 1.19 is out. |
|
Time for a retry? |
asger-semmle
force-pushed
the
lodash-case
branch
from
5714a3c to
45a5d0e
Compare
|
Should be ready to land - the test failures are for C++ so I assume they're unrelated. |
ghost
previously approved these changes
Jan 10, 2019
javascript/ql/src/semmle/javascript/frameworks/LodashUnderscore.qll
Outdated
Show resolved
Hide resolved
ghost
approved these changes
Jan 10, 2019
cklin
pushed a commit
that referenced
this pull request
May 23, 2022
Release preparation for version 2.7.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NPM package names are always lower-case, so the package
lodash.mergewithdoes not match the member_.mergeWith. This PR makesLodashUnderscore::membercase insensitive.