Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure unqualified program names are present on PATH before executing them. #309

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

chrisgavin
Copy link
Contributor

This avoids some potential issues when executing unqualified program names by using a custom library (which you can review here) to resolve them against the PATH variable first.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

@chrisgavin chrisgavin force-pushed the safe-which branch 5 times, most recently from b52982d to bfa70b3 Compare November 18, 2020 22:06
@chrisgavin chrisgavin marked this pull request as ready for review November 18, 2020 23:09
Copy link
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new dependency looks fine (the code looks good, and we got confirmation that using your library is fine). The rest of the code changes are pretty minimal. I've also reproduced the vulnerability and then that using your branch fixes it.

@chrisgavin chrisgavin merged commit 0924fb6 into main Nov 19, 2020
@chrisgavin chrisgavin deleted the safe-which branch November 19, 2020 13:52
@github-actions github-actions bot mentioned this pull request Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants