Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stack chart is incorrect or crashes when picking "Retained allocations" #5327

Open
mstange opened this issue Jan 17, 2025 · 0 comments
Open

Stack chart is incorrect or crashes when picking "Retained allocations" #5327

mstange opened this issue Jan 17, 2025 · 0 comments
Assignees
@mstange
Labels
allocations Issues related to the JS or native allocation feature stack chart Issues related to the stack chart panel

Comments

@mstange
Copy link
Contributor

mstange commented Jan 17, 2025 •
edited by data-sync-user
Loading

Profile: https://share.firefox.dev/40AuFJS

The stack chart looks strange.

And in a different thread of the same profile, switching from the call tree to the stack chart causes an error to be shown: https://share.firefox.dev/4gXUt8y

Should the stack chart use allocation samples, or should it always use timing samples?

┆Issue is synchronized with this Jira Task
@mstange mstange self-assigned this Jan 17, 2025
@mstange mstange mentioned this issue Jan 17, 2025
Merged
mstange added a commit that referenced this issue Jan 17, 2025
@mstange
Reduce confusion between call tree summary strategy aware samples and…
5431546 
… regular samples (#5330)

Fixes #5326, but leaves #5327 unfixed for now.
@canova canova added stack chart Issues related to the stack chart panel memory allocations Issues related to the JS or native allocation feature and removed memory labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mstange mstange

Labels
allocations Issues related to the JS or native allocation feature stack chart Issues related to the stack chart panel
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@canova @mstange