Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #4468 Preserv elemement text align format on new paragraph creation #5878

Merged
merged 1 commit into from
Apr 12, 2024
Merged

fix #4468 Preserv elemement text align format on new paragraph creation #5878

merged 1 commit into from
Apr 12, 2024

Conversation

Sahejkm
Copy link
Contributor

@Sahejkm Sahejkm commented Apr 12, 2024

Before

Screen.Recording.2024-04-12.at.10.45.36.AM.mov

After

Screen.Recording.2024-04-12.at.10.45.50.AM.mov

closes #4468

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 12, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview Apr 12, 2024 2:47am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2024 2:47am

potatowagon
potatowagon approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@potatowagon potatowagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions GitHub Actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.96 KB (+0.03% 🔺) 540 ms (+0.03% 🔺) 73 ms (+257.06% 🔺) 613 ms
packages/lexical-rich-text/dist/LexicalRichText.js 39.38 KB (+0.03% 🔺) 788 ms (+0.03% 🔺) 124 ms (+111.32% 🔺) 912 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 39.35 KB (+0.03% 🔺) 788 ms (+0.03% 🔺) 111 ms (+65.32% 🔺) 898 ms

@Sahejkm Sahejkm merged commit 421de25 into main Apr 12, 2024
45 checks passed
@acywatson acywatson mentioned this pull request Apr 16, 2024
Merged
@dmitrymarokhonov dmitrymarokhonov mentioned this pull request May 19, 2024
Open
@zurfyx zurfyx deleted the 4468 branch February 28, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@potatowagon potatowagon potatowagon approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug(?): New paragraph nodes do not follow the alignment of previous paragraphs.
4 participants
@Sahejkm @zurfyx @potatowagon @facebook-github-bot