@lexical/playground: Moved Vite config to TS and removed code duplication #5744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
StyleT
changed the title
StyleT
force-pushed
the
feature/playground_vite_optimization
branch
from
06735a7 to
22199de
Compare
StyleT
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
ivailop7
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
LGTM, I do think we can have the vite config as .mts (https://vitejs.dev/guide/troubleshooting#config) if we want to move more towards ESM practices.
|
Bumping the vite to v5 in package.json has been in my do list for a while. In case you want to give it a go. |
canastro
reviewed
Mar 28, 2024
| replacements: [ | ||
| { | ||
| from: /__DEV__/g, | ||
| to: 'true', |
|
This reverted the /esm/ example in the playground from #5618, I'll create another PR to restore it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we extract module resolution config to
viteModuleResolution.tsand move both Vite configs from.jsto.ts