Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

canInsertTextAfter exception for composition #5378

Merged
merged 1 commit into from
Dec 26, 2023
Merged

canInsertTextAfter exception for composition #5378

merged 1 commit into from
Dec 26, 2023

Conversation

zurfyx
Copy link
Member

@zurfyx zurfyx commented Dec 12, 2023

#5363 parity for canInsertAfter (see the other PR and #5162 for more details). On the playground, hashtags can be written after so I switched it to false to test.

Before

Screen.Recording.2023-12-12.at.10.04.20.AM.mov

After

Screen.Recording.2023-12-12.at.10.01.57.AM.mov

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 12, 2023
@vercel Vercel
Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview Dec 12, 2023 3:07pm
lexical-playground ✅ Ready (Inspect) Visit Preview Dec 12, 2023 3:07pm

@github-actions GitHub Actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.61 KB (+0.01% 🔺) 533 ms (+0.01% 🔺) 45 ms (+55.83% 🔺) 577 ms
packages/lexical-rich-text/dist/LexicalRichText.js 39.33 KB (+0.01% 🔺) 787 ms (+0.01% 🔺) 72 ms (+105.71% 🔺) 859 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 39.3 KB (+0.01% 🔺) 786 ms (+0.01% 🔺) 78 ms (+59.06% 🔺) 864 ms

@acywatson
Copy link
Contributor

Yea makes sense.

@acywatson acywatson merged commit a5b20c0 into main Dec 26, 2023
@zurfyx zurfyx deleted the textdomcontentcomposion branch February 28, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acywatson acywatson acywatson approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zurfyx @acywatson @facebook-github-bot