Bug Fix: added a fix for discarding multiple color picker entries on drag #5335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhavyakaria
requested review from
zurfyx,
fantactuka and
acywatson
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
|
PR is ready for review. |
zurfyx
reviewed
Dec 8, 2023
| @@ -186,14 +203,21 @@ function MoveWrapper({className, style, onChange, children}: MoveWrapperProps) { | |||
| move(e); | |||
|
|
|||
| const onMouseMove = (_e: MouseEvent): void => { | |||
| setDragged(true); | |||
| updateSkipHistoryFlag(true); | |||
There was a problem hiding this comment.
Do we need a useState here or can we do with useRef? It might be easier to debug later without the side effects of having this variable is the useEffect dependency. I believe even a module variable would suffice for this case since there can only be one event in total in the entire page
There was a problem hiding this comment.
@zurfyx Thanks for the review.
Agreed, useState was not necessary, have made he skipFlag to be module variable and dragged to be useRef
|
PR is ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #3890
Before:
290535690-733a836e-78ea-421f-8dbd-5b81485d7d90.mov
After:
Screen.Recording.2023-12-14.at.6.57.32.PM.mp4