Port List e2e test to unit tests #5030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
fantactuka
reviewed
Sep 22, 2023
|
|
||
| describe('@lexical/list tests', () => { | ||
| let container: HTMLDivElement | null = null; | ||
| let reactRoot; |
There was a problem hiding this comment.
Not a blocker, but I wonder if we even need react here? I guess list plugin should have registerList or similar exposed, then there's just less of react-related noise in the code
There was a problem hiding this comment.
I thought about this, but the reason I ultimately kept it is because I want to be able to easily compose the plugins, many of which don't expose neat handles in the same way as @lexical/list. Most things in @lexical/react are exposed as react components, and those are the bulk of what I want to test so we can get rid of some e2es
fantactuka
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP