Playground: refactor component picker plugin #4836
Conversation
thorn0
requested review from
zurfyx,
fantactuka,
acywatson and
thegreatercurve
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
|
Seems fine - what's the aim here? |
|
@acywatson I was reading through this code and noticed a bunch of small things. |
| return ( | ||
| regex.test(option.title) || | ||
| option.keywords?.some((keyword) => regex.test(keyword)) | ||
| ); |
There was a problem hiding this comment.
This is a bug fix (parens were missing around the ternary).
| const regex = new RegExp(queryString, 'i'); | ||
| return ( | ||
| regex.test(option.title) || | ||
| option.keywords?.some((keyword) => regex.test(keyword)) |
There was a problem hiding this comment.
keywords is not nullable so ?. is redundant
| ); | ||
| } | ||
|
|
||
| return options; |
There was a problem hiding this comment.
Full and partial table matchers can be replaced with a single one:
const tableMatch = queryString.match(/^(\d{1,2})x?(\d{1,2})?$/);
if (tableMatch !== null) {
const row = Number(tableMatch[1]);
const cols = tableMatch[2]
? [Number(tableMatch[2])]
: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10];
return cols.map(col => ({
icon: <i className="icon table" />,
label: `${row}x${col} Table`,
keywords: ['table'],
onSelect: (_: string) => {
...
},
}));
}
thorn0
force-pushed
the
refactor-component-picker
branch
from
972fab9 to
5f95647
Compare
No description provided.