Manifest V3 migration

[extesy]

https://developer.chrome.com/docs/extensions/develop/migrate

[extesy]

@LiliaDoe @GrosPoulet This branch is at the state that it currently loads as a valid Manifest V3 extension and actually works for a couple sites that I tried. Feel free to experiment with it, I need all the feedback I can get before I merge it into main branch.

[LiliaDoe]

Will do! Would you prefer it tested on chrome? Else, I'll test it mainly on firefox

[extesy]

Testing in Firefox would be perfect. I mostly use Chrome so it's good to have some coverage between different browsers.

[LiliaDoe]

My testing thus far has found a couple things.

• The first is an issue with the manifest for Firefox. I made a PR with a fix that should allow Chrome and Firefox to work.
• The second is a reoccuring error: Error: Could not establish connection. Receiving end does not exist. It's most consistent on https://www.furaffinity.net/, but I found it occurs on https://www.ebay.com/ upon initial load where it then goes away after the page finishes loading. It doesn't seem like "preloadAvailable" has a "message.action" case in function "onMessage" within "js/background.js". That may be what's causing the error

Everything else works great so far on Firefox!

[extesy]

Thank you for testing! I also noticed this "Receiving end does not exist" error when saving options but I haven't yet been able to figure out what is causing it.

[extesy]

Migration docs say that unlike background pages, service workers could shut down at any time and lose all their registered listeners. So maybe that is what's causing the problem.

[LiliaDoe]

I was seeing the error on the master branch too in reddit, while debugging that Reddit video issue.

Edit: I double checked today, and I don't see the error showing on master branch now. Maybe it was on my end

[extesy]

@LiliaDoe I've made some fixes recently - the options can be saved now without errors but they don't seem to be updating other pages immediately, so a reload is required. Other than that, everything seems to work. Can you please re-check? I think I can live with options requiring a reload if it lets us restore the extension in Chrome web store.

[LiliaDoe]

@extesy https://www.furaffinity.net/ still does not work, showing the same error. Direct image links on the site still work as expected. This makes me think the error message is being sent when part of the prepareFromDocument function is triggered:

chrome.runtime.sendMessage({action:'ajaxRequest', url: url, method: 'GET'}, function(data) {

The error occurs on many other sites, but without affecting functionality. Options can be saved for me as well, despite the connection error showing.

I'm not sure how to fix it. The background worker is online when it happens. It's like the listener just doesn't exist. It may be related to the listener not registering in time: https://developer.chrome.com/docs/extensions/develop/migrate/to-service-workers#register-listeners

[extesy]

@LiliaDoe How about now? I checked https://www.furaffinity.net and I don't see connection errors in console.

[LiliaDoe]

@extesy I see it working on Chrome too, but the error still persists on Firefox. I'll see if the Mozilla docs have anything about this (https://extensionworkshop.com/documentation/develop/manifest-v3-migration-guide/)

Edit: I found an error in the background page. importScripts is throwing an error, but only in Firefox:

14:00:49.891 Uncaught ReferenceError: importScripts is not defined
    <anonymous> moz-extension://9739b5ce-f8b8-4f65-ba52-f60f83c9d221/js/background.js:1
background.js:1:1

Fixing it didn't seem to fix it not working, though. Also, onMessage in background.js doesn't seem to be called at all in Firefox

[LiliaDoe]

I found a separate issue within firefox. In the permissions, every url that has a plugin for it is listed

[extesy]

@LiliaDoe I fixed importScripts error in Firefox, please check it out.

[sonarqubecloud]

Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud