-
-
Notifications
You must be signed in to change notification settings - Fork 435
Ternary conditional causes EOF errors in version 1.17 breaking backwards compatibility #772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
Ohh! This is a bug! Both syntaxes should be supported. |
Releases https://github.com/expr-lang/expr/releases/tag/v1.17.1 with a fix. |
Any chance of getting the fix for the playground as well? |
Done! |
SimFG
pushed a commit
to SimFG/expr
that referenced
this issue
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the latest version (1.17) this script is failing in the playground (Probably related to #736):
It returns:
In earlier versions this returned "1". The structure could be used for building conditional statements similar to the newly introduced if-else. While the newly introduces syntax is very welcome, perhaps it would be possible to restore support for the old format as well or make this a major version release instead of a minor one.
Moving from old syntax to new one will require considerable effort for larger codebases and it is hard to force customers to upgrade all their own code just because we want to update the library version.
Is this change deliberate or accidental? Perhaps I am missing something here?
The text was updated successfully, but these errors were encountered: