-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skinny CREATE2 #1014
Merged
Merged
Skinny CREATE2 #1014
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
600fba9
Create Skinny_CREATE2.md
vbuterin b77eea1
Update Skinny_CREATE2.md
vbuterin c3131c6
Update and rename Skinny_CREATE2.md to eip-1014.md
vbuterin c368b27
Update eip-1014.md
vbuterin 89e9a1e
Update eip-1014.md
vbuterin 5a38a07
Update eip-1014.md
vbuterin 036d374
Update eip-1014.md
vbuterin 4bb9007
Merge branch 'master' into vbuterin-patch-2
Arachnid b9c28ee
Merge branch 'master' into vbuterin-patch-2
Arachnid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update eip-1014.md
- Loading branch information
commit 5a38a070ec136bc1624f41ff4e67e91c082bc5ac
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading from the comments it's:
sha3(0xff ++ msg.sender ++ salt ++ sha3(init_code))[12:]
instead of
sha3(0xff ++ msg.sender ++ salt ++ init_code)[12:]
so with the hash value
sha3(init_code)
and not the code itself. Am I correct on this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see #1375 . But yes, the
init_code
, not the code itselfThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks!