Add changes in embed.EtcdServer struct for feature gate.
#973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: siyuanfoundation The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
siyuanfoundation
force-pushed
the
embed
branch
6 times, most recently
from
48e35f6 to
c608503
Compare
jmhbnz
reviewed
Mar 18, 2025
Signed-off-by: Siyuan Zhang <sizhang@google.com>
jmhbnz
reviewed
Mar 23, 2025
Comment on lines
+75
to
+81
| | CompactHashCheck | false | Alpha |Enables to check data corruption before serving any client/peer traffic. | | ||
| | InitialCorruptCheck | false | Alpha |Enables the write transaction to use a shared buffer in its readonly check operations. | | ||
| | LeaseCheckpoint | false | Alpha |Enables leader to send regular checkpoints to other members to prevent reset of remaining TTL on leader change. | | ||
| | LeaseCheckpointPersist | false | Alpha |Enables persisting remainingTTL to prevent indefinite auto-renewal of long lived leases. | | ||
| | SetMemberLocalAddr | false | Alpha |Enables using the first specified and non-loopback local address from initial-advertise-peer-urls as the local address when communicating with a peer. | | ||
| | StopGRPCServiceOnDefrag | false | Alpha |Enables etcd gRPC service to stop serving client requests on defragmentation. | | ||
| | TxnModeWriteWithSharedBuffer | true | Beta |Enables leader to periodically check followers compaction hashes. | |
There was a problem hiding this comment.
Double checking is it intentional that DistributedTracing: {Default: false, PreRelease: featuregate.Alpha} is excluded from this list?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#962