migrate experimental-memory-mlock flag to memory-mlock

[jmao-dd]

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

This fixes #19061

[k8s-ci-robot]

Hi @jmao-dd. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.75%. Comparing base (dd60559) to head (8d5be6e).
Report is 2 commits behind head on main.

Additional details and impacted files

Files with missing lines	Coverage Δ
server/config/config.go	80.23% <ø> (ø)
server/embed/config.go	79.72% <100.00%> (+0.06%)	⬆️
server/embed/etcd.go	76.49% <100.00%> (ø)
server/etcdmain/config.go	73.49% <100.00%> (+0.32%)	⬆️
server/storage/backend.go	72.72% <100.00%> (ø)

... and 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19282      +/-   ##
==========================================
- Coverage   68.84%   68.75%   -0.09%     
==========================================
  Files         420      420              
  Lines       35693    35697       +4     
==========================================
- Hits        24573    24544      -29     
- Misses       9698     9722      +24     
- Partials     1422     1431       +9     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd60559...8d5be6e. Read the comment docs.

[ahrtr]

/ok-to-test

[jmao-dd]

I am not sure if Member is the right category to add --memory-mlock. Please let me know if it isn't.

[jmao-dd]

/retest

[k8s-ci-robot]

@jmao-dd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-etcd-release-tests	52a91e2	link	false	/test pull-etcd-release-tests

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[ahrtr]

LGTM

Thanks

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, jmao-dd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahrtr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment