Fixes baudrate with CPU Freq < 80MHz #6037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
P-R-O-C-H-Y
reviewed
Dec 19, 2021
cores/esp32/esp32-hal-uart.c
Outdated
| // baudrate must be multiplied when CPU Frequency is lower than APB 80MHz | ||
| uint32_t _get_effective_baudrate(uint32_t baudrate) | ||
| { | ||
| uint32_t Freq = getCpuFrequencyMhz(); |
There was a problem hiding this comment.
Maybe more clearer if you use getApbFrequency() which is related to UART.
But it will return frequency in Hz, not in MHz.
Just an idea, will work the same.
There was a problem hiding this comment.
Yes, it gets better and clear. DONE. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue with UART when CPUFreq is lower than 80MHz (APB Freq)
Impact
No impact beside the fix.
Related links
Fix #6032