Skip to content

OTA success reporting fix #2202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2018
Merged

OTA success reporting fix #2202

merged 1 commit into from
Dec 16, 2018

Conversation

petefats
Copy link
Contributor

This PR piggybacks on #1695. @Gei0r originally reported that while the update was successful, it was reported erroneous by espota.py. I've run into another similar condition, where the expected "OK" is coming concatenated with another recv.

07:38:54 [DEBUG]: Options: {'timeout': 10, 'esp_ip': '10.4.20.20', 'host_port': 13414, 'image': '.pioenvs/esp12e_0/firmware.bin', 'host_ip': '0.0.0.0', 'auth': '', 'esp_port': 8266, 'spiffs': False, 'debug': True, 'progress': True}
07:38:54 [INFO]: Starting on 0.0.0.0:13414
07:38:54 [INFO]: Upload size: 293792
Sending invitation to 10.4.20.20
07:38:54 [INFO]: Waiting for device...
Uploading: [============================================================] 100% Done...

07:39:00 [INFO]: Waiting for result...
07:39:00 [INFO]: Result: 536
07:39:00 [INFO]: Result: 392OK
07:39:00 [INFO]: Result:
07:39:00 [INFO]: Result:
07:39:00 [INFO]: Result:
07:39:00 [ERROR]: Error response from device
*** [upload] Error 1

@me-no-dev me-no-dev merged commit 25fd2d0 into espressif:master Dec 16, 2018
@me-no-dev
Copy link
Member

awesome :) thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants