Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmp-start #5352

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

jukie
Copy link
Contributor

@jukie jukie commented Feb 26, 2025

What type of PR is this?

What this PR does / why we need it:

Splitting up implementation for #1909 into two separate changes. #5299 for the internal logic to make zone aware routing available and this one for the Kubernetes side and making the individual Envoy Proxy instances aware of their local zone.

Which issue(s) this PR fixes:

xRef #1909

Release Notes: Yes/No

Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 11.62791% with 152 lines in your changes missing coverage. Please review.

Project coverage is 64.93%. Comparing base (4d914ae) to head (0529343).

Files with missing lines Patch % Lines
internal/cmd/envoy/envoy_init.go 0.00% 74 Missing ⚠️
...ternal/infrastructure/kubernetes/proxy/resource.go 0.00% 58 Missing ⚠️
api/v1alpha1/kubernetes_helpers.go 0.00% 10 Missing ⚠️
api/v1alpha1/envoyproxy_helpers.go 0.00% 7 Missing ⚠️
internal/cmd/envoy.go 86.95% 2 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (11.62%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5352      +/-   ##
==========================================
- Coverage   65.16%   64.93%   -0.23%     
==========================================
  Files         212      213       +1     
  Lines       33691    33863     +172     
==========================================
+ Hits        21955    21990      +35     
- Misses      10410    10551     +141     
+ Partials     1326     1322       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jukie jukie mentioned this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant