Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an unused module-level constant EmptyList #1366

Merged
merged 2 commits into from
Nov 18, 2020

Conversation

mdickinson
Copy link
Member

@mdickinson mdickinson commented Nov 18, 2020

The only internal use of EmptyList disappeared at some point between Traits 4.3.0 and Traits 4.4.0.

This change will break external code that's doing from traits.has_traits import EmptyList. I'm finding it hard to care much about that.

Checklist

  • Tests - n/a
  • Update API reference (docs/source/traits_api_reference) - n/a
  • Update User manual (docs/source/traits_user_manual) - n/a
  • Update type annotation hints in traits-stubs

The only internal use of `EmptyList` disappeared at some point between Traits 4.3.0 and Traits 4.4.0.

This change will break external code that's doing `from traits.has_traits import EmptyList`. I'm finding it hard to care much about that.
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdickinson mdickinson merged commit 7558f98 into master Nov 18, 2020
@mdickinson mdickinson deleted the kill-the-empty-list branch November 18, 2020 16:12
@mdickinson mdickinson changed the title Remove an unused module-level constant Remove an unused module-level constant EmptyList Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants