Prevent test_enum failures if traitsui or GUI toolkit are not installed #1349
Conversation
traits/tests/test_enum.py
Outdated
| from traits.testing.optional_dependencies import pyface, requires_traitsui | ||
|
|
||
| if pyface is not None: | ||
| GuiTestAssistant = pyface.toolkit.toolkit_object( | ||
| is_qt = ETSConfig.toolkit.startswith('qt') |
There was a problem hiding this comment.
the copying of this here is related to this comment:
enthought/enable#444 (review)
There was a problem hiding this comment.
Aha, the only GUI test here is skipped if traitsui is not available and can be rewritten using UITester like this:
# this opens and closes the GUI to exercise initialization of the default traitsui editor for Enum
with UITester().create_ui(obj):
pass
So rewriting the test not to depend on GuiTestAssistant is also an alternative...
There was a problem hiding this comment.
I'm worried about compatibility constraints here, though. I'm not sure we want Traits 6.2.0 to depend on TraitsUI latest.
In practice, people upgrading to the latest set of ETS packages should be able to do it in two separate steps:
- Upgrade Traits
- Upgrade TraitsUI and Pyface.
OTOH, this is only in tests, so it's only the Traits test suite that ends up requiring the latest TraitsUI. I guess that doesn't affect users.
Fixes #1266
In this PR I first simply broke
pyface.toolkit.toolkit_objectup intofrom pyface.toolkit import toolkit_objectand then calledtoolkit_object. This fixed theAttributeError: module 'pyface' has no attribute 'toolkit'error mentioned in the issue. CurrentlyGUITestAssistantis only implemented on Qt, so I also added anis_qtcheck before trying to getGUITestAssistantviatoolkit_object, and I also skipped the test that needsqtifqtis not available. This may or may not be the right solution as the code is basically coped over from https://github.com/enthought/traitsui/blob/770e94346e06dc70909f125ba7237edce90872da/traitsui/tests/_tools.py#L50-L54The tests no longer failed if pyface is installed but traitsui is not, or if traitsui/pyface are installed by pyside2 (or pyqt5) is not.
Checklist
- [ ] Tests- [ ] Update API reference (docs/source/traits_api_reference)- [ ] Update User manual (docs/source/traits_user_manual)- [ ] Update type annotation hints intraits-stubs