Use flake8_ets instead of local copyright_header #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of copyright_header local package deleted: copyright_header/copyright_header.py deleted: copyright_header/setup.py modified: etstool.py
rahulporuri
changed the title
and dont install the now non-existent copyright_header package in CI modified: .github/workflows/run-style-checks.yml modified: .travis.yml modified: appveyor.yml modified: setup.py
|
I made PR #1342 to double check that the header checks work as advertised. |
And it does - all three of Travis CI, Appveyor and GitHub Actions failed in the expected manner. I really like that we get those results from GitHub Actions within 30 seconds of the PR being submitted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1340
This PR removes the local package
copyright_headerand uses the new edm packageflake8_etsin its place.Checklist
TestsUpdate API reference (docs/source/traits_api_reference)Update User manual (docs/source/traits_user_manual)Update type annotation hints intraits-stubs