Correct the minimum Sphinx version in README #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We require Sphinx >= 2.1. Related: #1216.
kitchoi
approved these changes
Oct 21, 2020
|
Since I'm touching this, I also restored the minimum version requirement for Sphinx (and removed the version restriction in the EDM package versions, since it's unlikely ever to be relevant - we'll never be building Sphinx 3.2.0 for EDM). |
|
Sorry, @kitchoi; I should have refrained from updating the PR after your review. I can make a new PR with the new changes if that's better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We require Sphinx >= 2.1. That requirement used to be encoded in the
setup.py, but was removed in #1276.Related: #1216.